Improve postinstall message to detect existing Chrome installations#815
Merged
Improve postinstall message to detect existing Chrome installations#815
Conversation
Previously, the npm postinstall script always recommended running `agent-browser install` to download Chrome for Testing, even when users already had a working Chrome installation on their system. This change adds Chrome detection logic to the postinstall script that mirrors the runtime behavior: - Checks for system Chrome installations on macOS, Linux, and Windows - Shows a success message when Chrome is found, indicating it will be used automatically - Only shows the `agent-browser install` warning when no Chrome is detected - Provides platform-specific guidance (Linux `--with-deps` flag, `--executable-path` alternative) The detection logic matches the existing Rust `find_chrome()` implementation to ensure consistency between postinstall messaging and runtime behavior. Fixes #814
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the npm postinstall script always recommended running
agent-browser installto download Chrome for Testing, even when users already had a working Chrome installation on their system.This change adds Chrome detection logic to the postinstall script that mirrors the runtime behavior:
agent-browser installwarning when no Chrome is detected--with-depsflag,--executable-pathalternative)The detection logic matches the existing Rust
find_chrome()implementation to ensure consistency between postinstall messaging and runtime behavior.Fixes #814